Don't use perl#68
Open
Sneethe wants to merge 2 commits into
Open
Conversation
akinomyoga
reviewed
Jul 6, 2025
akinomyoga
left a comment
akinomyoga
left a comment
Collaborator
There was a problem hiding this comment.
Doesn't grep -vxF work?
Author
Yeah thats a lot simpler. I was striving for only using ZSH builtins. |
akinomyoga
reviewed
Jul 7, 2025
| && echo "** The following mark has been deleted **" \ | ||
| || echo "** The following marks have been deleted **" | ||
| _fzm_color_marks <<< $marks_to_delete | ||
| command grep -vxF "$marks_to_delete" "$bookmarks" > "$bookmarks.tmp" |
Use akinomyoga suggestion instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not every Linux or BSD includes perl. And doing this just in ZSH is probably faster anyway.