Use initial query as pre-filter expression over mark names if provided#57
Open
bmundt6 wants to merge 1 commit into
Open
Use initial query as pre-filter expression over mark names if provided#57bmundt6 wants to merge 1 commit into
bmundt6 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this update, an additional pass of
fzfin filter mode runs on the marks list, fuzzy-matching field 1 (mark name) against the strings provided on the command-line, if any. Then, the scope of the interactive search is limited only to bookmarks matching the query, and the initial query string is always empty.This pairs well with #55 and with command-line TAB completion, since any string provided in the initial
fzmcall is always understood to be some part of a mark name, not a path component. A basic example use case: suppose I have marksfooandfoobaramong others and I begin typingjump fo. Then I hit TAB, and the command-line becomesjump foo. Then, I hit enter, andfzmshows me only two options to select from,fooandfoobar, no matter what path components in other marks might also match the stringfoo.