fix: return an error instead of panicking when scanning JSON into an unaddressable value - #1393
Open
Yusufihsangorgel wants to merge 1 commit into
Open
Conversation
…unaddressable value A non-nil interface field routes the scan to the element value, which is not addressable, so scanJSON panicked on dest.Addr() and the connection was left in idle-in-transaction. The JSON scan paths now pre-check CanAddr and fail with an error, as suggested in uptrace#1306.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Scanning a JSONB column into a non-nil
anyfield routes throughscanJSONIntoInterface, which dispatches on the interface element. That element is not addressable, soscanJSONpanicked ondest.Addr(), and with the reporter's setup the panic left the connectionidle in transactionand the query blocked.Following the suggestion in the issue, the JSON scan paths (
scanJSON,scanJSONUseNumber, and the interface dispatch) now pre-checkCanAddrand return abun: Scan(nonaddressable ...)error early instead of panicking, mirroring howdatabase/sqlreportsScan(nonsettable ...).Two tests: the regression case (non-nil interface, previously a panic, now an error and no panic) and the addressable map path to pin that normal JSON scanning is unaffected.
go test ./...on the root module passes.