bsd_close_socket preserves the error code#196
Closed
aditmak wants to merge 0 commit into
Closed
Conversation
uNetworkingAB
force-pushed
the
master
branch
4 times, most recently
from
March 1, 2023 03:38
3bc1f9d to
d29d5ba
Compare
|
This PR was submitted by someone in our company some time ago, but the source branch was mistakenly specified as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using the uWebsocket application. When I call the application's listen function to open the port and begin listening it failed.
Because the application failed to listen, it closes the socket and exits gracefully. So, if there is an error while opening the port, the errno variable is updated with the error code then the close socket function is called and it updates the errno, causing the error information from the listening socket failure to be lost.
By preserving the errno after the close socket function, the real error can be determined.