Skip to content

WIP: Refactoring & Fix issue on nvim#101

Open
lambdalisue wants to merge 7 commits into
tyru:masterfrom
lambdalisue:master
Open

WIP: Refactoring & Fix issue on nvim#101
lambdalisue wants to merge 7 commits into
tyru:masterfrom
lambdalisue:master

Conversation

@lambdalisue

@lambdalisue lambdalisue commented Jul 23, 2017

Copy link
Copy Markdown

@lambdalisue lambdalisue changed the title Refactoring & Fix issue on nvim WIP: Refactoring & Fix issue on nvim Jul 23, 2017
@lambdalisue

Copy link
Copy Markdown
Author

I'll fix tests later.

Btw, the behavior was tested only in macOS Sierra so it should be tested in other platform as well.

Comment thread autoload/openbrowser.vim
return 0
endfunction "}}}

function! openbrowser#__system__(...)

@tyru tyru Jul 23, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this function, please use s:Process.execute() in this function.
It should also pass failed tests.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@tyru

tyru commented Jul 25, 2017

Copy link
Copy Markdown
Owner

@lambdalisue Does this PR fix #102 too?

@tyru

tyru commented Jul 28, 2017

Copy link
Copy Markdown
Owner

ping

@lambdalisue

Copy link
Copy Markdown
Author

Yes but to support neovim correctly, it should use System.Process.Job internally.

@tyru

tyru commented Jul 28, 2017

Copy link
Copy Markdown
Owner

@lambdalisue hm, like this? (I don't know if System.Process and System.Process.Job is compatible...)

-let s:Process = vital#openbrowser#import('System.Process')
+let s:Process = vital#openbrowser#import('System.Process.Job')

@lambdalisue

Copy link
Copy Markdown
Author

We have to wait vim-jp/vital.vim#513
After that, we can use clients options like https://github.com/vim-jp/vital.vim/blob/master/doc/vital/System/Process.txt#L54-L64

@tyru

tyru commented Aug 3, 2017

Copy link
Copy Markdown
Owner

@lambdalisue Okay. I made a workaround about this in #104.
I'm looking forward to your fix :)

@lambdalisue

Copy link
Copy Markdown
Author

I'm looking forward to your fix :)

So would you want to wait System.Process.Job?

@tyru

tyru commented Aug 4, 2017

Copy link
Copy Markdown
Owner

Yes.
To fix this issue completely, vital.vim must be fixed, I think. isn't it?

@lambdalisue

Copy link
Copy Markdown
Author

Ok!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants