Skip to content

Update Finagle to 22.12.0 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanvdm merged 5 commits into from
Mar 6, 2023
Merged

Update Finagle to 22.12.0 #521

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3607a39
Add Finagle 22.12.0 to MiMa
Mar 1, 2023
bf563b7
Update Finagle to 22.12.0
milanvdm Mar 1, 2023
59b8e00
Add MiMa check to the root
Mar 3, 2023
57344fc
Merge branch 'local-mima' into update-finagle
Mar 3, 2023
bd016c0
Remove Finagle
Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/FinaglePlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ object FinaglePlugin extends AutoPlugin {
* because the newest release is not binary compatible with the older
* versions it was checked against.
*/
val versions = Seq("22.7.0")
val versions = Seq("22.12.0", "22.7.0")

@bpholt bpholt Mar 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be explicit: I think we should remove "22.7.0" here, since we know 22.12.0 is not binary compatible with 22.7.0. Once that's done, rootFinagle/mimaReportBinaryIssues should run cleanly, and we can add it to the build.


lazy val modules = Seq(
"com.twitter" %% "finagle-core" % versions.head
Expand Down