This repository was archived by the owner on May 27, 2026. It is now read-only.
Repository navigation
Bump Node engine to 22 LTS to fix Heroku build - #1057
Merged
Merged
Conversation
Node 18 lacks the global `crypto` object that serialize-javascript (via css-minimizer-webpack-plugin) requires, causing webpack builds to fail on Heroku. Node 18 is also EOL. Bump the npm constraint to match the version bundled with Node 22, and pin CI to the engines field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
coverage: 91.534%. remained the same — fix/node-22-engine into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cryptoobject thatserialize-javascript(pulled in viacss-minimizer-webpack-plugin) requires, so the Heroku build fails in the CSS minify step withReferenceError: crypto is not defined. Node 18 is also EOL on Heroku.engines.nodeto>=22 <23(current LTS) andengines.npmto10.x(the version bundled with Node 22).setup-nodeto read frompackage.jsonsoengine-strict: truedoesn't surprise us on whatever default the runner ships.Test plan
npm run buildsucceeds locally on Node 22+ (verified on Node 24).integrationworkflow passes on the new Node version.🤖 Generated with Claude Code