docs: add duplicate-changelog-entry check to release PR review steps - #44
Merged
Conversation
A merged PR whose title is in Conventional Commits form gets that title embedded in the merge commit body, and release-please may extract it as an extra changelog entry alongside the PR's actual commits (observed with PR #42). The trigger conditions are not fully understood, so make the check part of every release PR review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the 0.7.1/0.5.1/0.3.2/0.2.2/0.8.1 release. During the release PR (#43) review, each affected CHANGELOG contained the same fix entry twice: once linking the actual commit (5bf0642) and once linking the merge commit of PR #42 (c880922). GitHub's merge commits carry the PR title in their body, and since that title was in Conventional Commits form, release-please extracted it as an additional entry.
Notably, PR #28 had the same structure (conventional title, plain merge) and did not produce duplicates in the 0.7.0 release, so the trigger conditions are not fully understood. Rather than relying on title conventions to avoid it, add the duplicate check to the release PR review steps in RELEASING.md so it is caught every time; the fix is the already-documented hand-edit procedure.
🤖 Generated with Claude Code