Skip to content

Convert char to unsigned before calling ctype.h functions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fghzxm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert char to unsigned before calling ctype.h functions #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bscanf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ int bscanf(const char *buffer, const char *format, ...)

while ('\0' != *fmt_ptr) {
/* We ignore spaces before specifiers. */
if (isspace(*fmt_ptr)) {
if (isspace((unsigned char)*fmt_ptr)) {
/* Any whitespace in the format consumes all of the whitespace in the
buffer. */
_BSCANF_CONSUME_WSPACE();
Expand All @@ -74,7 +74,7 @@ int bscanf(const char *buffer, const char *format, ...)
}

/* Check for maximum field width. */
if (isdigit(*fmt_ptr)) {
if (isdigit((unsigned char)*fmt_ptr)) {
max_width = strtoul(fmt_ptr, &end_ptr, 0);
/* Check if the sequence is a number > 0. */
_BSCANF_CHECK(fmt_ptr != end_ptr);
Expand Down Expand Up @@ -138,7 +138,7 @@ int bscanf(const char *buffer, const char *format, ...)
/* Consume the character (string) and ignore it in this case. */
for (; max_width > 0; max_width--) {
buf_ptr++;
if (*buf_ptr == '\0' || (isspace(*buf_ptr) && 's' == *fmt_ptr)) {
if (*buf_ptr == '\0' || (isspace((unsigned char)*buf_ptr) && 's' == *fmt_ptr)) {
break;
}
}
Expand All @@ -157,7 +157,7 @@ int bscanf(const char *buffer, const char *format, ...)

for (; max_width > 0; max_width--) {
*char_ptr = *buf_ptr;
if (*buf_ptr == '\0' || (isspace(*buf_ptr) && 's' == *fmt_ptr)) {
if (*buf_ptr == '\0' || (isspace((unsigned char)*buf_ptr) && 's' == *fmt_ptr)) {
break;
}
char_ptr++;
Expand Down