Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0hmX
marked this pull request as ready for review
October 27, 2026 18:45
0hmX
marked this pull request as draft
October 27, 2026 18:48
0hmX
marked this pull request as ready for review
October 27, 2026 18:51
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0hmx@dots
When files change during a slow render, RunFrame currently invalidates the active generation immediately. Continuous edits can keep discarding completed work, and each rerender can briefly replace a completed PCB with an intermediate snapshot. The mutex also releases its lock on cancellation while the worker may still be rendering.
Keep one active render and only the newest pending request. Let a successful active render finish before starting the latest snapshot, so continuous editing makes progress and an older completion cannot overwrite a newer run. Cancellation clears queued work while retaining the worker lock until settlement. Preserve the existing preview until the replacement render finishes; initial loads still show their initial snapshot. Superseded failures are ignored while current failures remain visible and recover on the next edit.
Normalize the absent entrypoint comparison (
undefinedversusnull) so identical file maps do not spuriously rerun, while still rerunning when the selected main component or evaluator version changes.Validation on macOS with Bun 1.3.14:
The companion CLI PR #5612 batches filesystem changes using a bounded 250 ms trailing debounce. This scheduling fix is independent of that debounce. No circuit engine, board design, authentication, or networking behavior is changed.
Hosted validation on
a95f3335abf9f59ddd66eb99e806a14199820628: Bun tests, formatting, types, and Vercel preview checks all passed. The fix reaches standard CLI installations after a runframe release is incorporated into the standalone browser bundle distributed with tscircuit; the paired patches are already active together in the tested local installation.Automated-review follow-up: split the three queue cases into separate numbered test files to follow the repository's one-test-per-file convention. The test bodies and runtime code are unchanged; the three split tests pass locally and the current-head hosted suite passes.