Repository navigation
fix(runframe): recover polling error on reconnect and keep newest events (fixes tscircuit/tscircuit#5368) - #5891
Open
duongynhi000005-oss wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Author
|
Keeping active for review. Clean CI passing and ready for merge. |
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/components/RunFrameWithApi/store.ts, clearstate.errorwhen pollinggetEventssucceeds after a previous network/server failure.errorwas set but never reset tonullon subsequent successful polls, causing the UIApiStatusIndicatorto be stuck indefinitely displaying red "Dev server disconnected".store.ts, changerecentEventsqueue slicing to.slice(-100)instead of.slice(0, 100).recentEventsreached 100 events,.slice(0, 100)kept the oldest 100 events and discarded all newly arrived events.lib/components/RunFrameWithApi/api-base.ts, makewindow.TSCIRCUIT_FILESERVER_API_BASE_URLaccess safe in SSR/Node/Bun test environments withtypeof window !== "undefined".tests/runframe-api-polling-recovery.test.tsverifying error state recovery and newest event retention.Fixes tscircuit/tscircuit#5368
/claim tscircuit/tscircuit#5368