You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(polling): preserve independent local saves while requests are pending - #5772
Record only the polling batch's FILE_UPDATED and FILE_DELETED changes in updates instead of cloning state.fsMap before awaiting file requests.
Apply those updates with a functional set((currentState) => ...) merger against the latest currentState.fsMap so concurrent local saves (upsertFile) that finish while /events/list or /files/get requests are pending are preserved.
Add regression tests verifying that concurrent local updates and additions are preserved while either the event list or file content request is pending.
Still relevant: #5619 is open and this is the only PR addressing it. Branch is mergeable with all checks green. Happy to adjust the approach if you prefer a different merge strategy for the polling updates.
Still actively tracking this fix (#5619 — preserving independent local saves while polling requests are pending). Branch is CLEAN and all checks are passing. Happy to make any adjustments on review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILE_UPDATEDandFILE_DELETEDchanges inupdatesinstead of cloningstate.fsMapbefore awaiting file requests.set((currentState) => ...)merger against the latestcurrentState.fsMapso concurrent local saves (upsertFile) that finish while/events/listor/files/getrequests are pending are preserved.Fixes #5619
/claim #5619