Repository navigation
Add symbol contain fitting and local viewbox bounds (#4698) - #942
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom symbols need a way to preserve their proportions during sizing and define their own source bounds. Adds optional
fit="fill" | "contain" | "stretch"andviewbox={{ minX, maxX, minY, maxY }}to the public symbol props and runtime validation, enabling tscircuit/core#4706.containrequests uniform scaling; CSS-stylefilland explicitstretchretain independent scaling. Viewbox bounds use the local symbol coordinate space (mm, +X right, +Y up), accept numbers or distance strings, and requiremaxX > minXandmaxY > minY. Existing defaults are preserved. Generated API documentation is included.Follows Seve’s fit-mode review and min/max bounds review.
Validation: all 683 tests, full TypeScript checking, package/declaration build, and all four documentation generators pass. The current PR head has the same Git tree as the validated fix. Hosted test, typecheck, formatting, and package-preview checks are green.
Includes the fix already merged in #943. This PR targets
mainand now contains both the repro tests and their implementation, with ordinary passing assertions. After it lands and a props release is published, core#4706 can replace its preview dependency with that published version.