Repository navigation
test: reproduce native testpoint Circuit JSON import failure - #4978
rushabhcodes wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -0,0 +1,57 @@ | |||
| import { getTestFixture } from "./get-test-fixture" | |||
|
|
|||
| export const getTestPointInflationFixture = async () => { | |||
There was a problem hiding this comment.
The file name get-testpoint-inflation-fixture.tsx does not consistently match the exported function name getTestPointInflationFixture. The kebab-case equivalent of getTestPointInflationFixture would be get-test-point-inflation-fixture.tsx (note the hyphen between 'test' and 'point'). The current filename collapses 'TestPoint' into 'testpoint' without a hyphen, making it inconsistent with the project's naming convention where file names should match at least one export name in kebab-case. Rename the file to get-test-point-inflation-fixture.tsx to match the export name.
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
7539ff0 to
ded72c3
Compare
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
ded72c3 to
122c530
Compare
Saved native
<testpoint />components cannot be imported from Circuit JSON becausesimple_test_pointhas no inflator. Add an AM3352 SBC USB-C power-output fixture, reproduce the failure withtest.failing, and capture the missing imported result beside the original circuit.The regression checks the native testpoint’s source properties, pad geometry and placement, ports, net connections, label text, and saved copper. This PR contains only the fixture, the two reproduction tests, and their visual baseline.
Validation: both reproduction checks pass with Bun 1.4.2, including the expected import failure. No production code changes.
First PR in native GitHub stack #4980. Fixed by #4979. Replaces #4851.