Repository navigation
repro: saved-board import exposes a PCB antenna's masked feed pad - #4972
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
changed the title
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
rushabhcodes
force-pushed
the
repro/smtpad-mask-round-trip
branch
from
November 2, 2026 05:40
2b147b1 to
a35cb11
Compare
rushabhcodes
marked this pull request as ready for review
November 2, 2026 05:41
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
rushabhcodes
force-pushed
the
repro/smtpad-mask-round-trip
branch
from
November 2, 2026 05:48
4712f9f to
d037978
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving and re-importing a board exposes the masked feed pad of Core's PCB antenna component.
The reproduction uses
<antenna name="ANT1" antennaShape="2.4ghz_meandered_monopole" />. The component generates its own antenna copper, keepout and masked 0.8 × 0.8 mm feed pad. After JSON serialization and public<subcircuit circuitJson={...}>import, the feed'sis_covered_with_solder_maskchanges fromtruetofalse.Both regression tests use
test.failing, so CI passes while verifying that the solder-mask import bug is still reproducible. The fix in #4973 restores regulartestcalls. The antenna test captures one snapshot of the imported board before asserting that its feed must remain masked. The secondary regression uses numeric assertions for all six pad shapes on both layers, positive/zero/negative margins, omitted defaults, and saved-JSON immutability. It exposes ten lost coverage flags and thirty dropped margins; polygon pads preserve the settings.Validation:
bun test tests/repros/repro-antenna-mask-round-trip.test.tsx tests/repros/repro-smtpad-mask-round-trip.test.tsxpasses both expected-failure tests (Bun 1.3.3). Gerber validation withcircuit-json-to-gerber@0.0.121confirms the antenna changes from zero mask openings to one unintended opening.Fix: #4973, the next layer in native GitHub stack #4976.
The single snapshot shows the imported antenna. Hatching marks the copper keepout; the red feed square is the unintended exposed copper.