[imrishabh18]

Core and Footprinter could both generate polarity artwork for LEDs, producing duplicate symbols. Bare LED package sizes also selected resistor definitions. Resolve each component's effective footprint and let Footprinter generate the requested artwork.

• Use published Footprinter 0.0.450 and its resolvePassiveFootprintDefinition API to select capacitor and diode families while retaining explicit families, dimensions, units, and modifiers.
• Chip.resolveFootprint() requests _nonpolarized only for diode/LED packages that generate automatic electrical polarity artwork. Ordinary chip footprints such as soic8, qfn32, and dip8 retain their definitions. Explicit polarity modifiers are preserved.
• Capacitor.getFootprinterString() owns capacitor family selection, polarity options, and terminal mapping. PCB and CAD use the same definition.
• Diodes and LEDs share diode-specific footprint and port helpers under lib/utils/footprints/. Component class files retain their class export; a CI regression rejects additional runtime exports in normal component class files.
• Read parameters directly from Footprinter instead of maintaining a duplicate Zod schema. Convert authored pin options at the terminal-mapping boundary, preserving label conflict checks and distinct numeric 1 | 2 terminals.
• Keep NormalComponent generic and authored props immutable. Remove core's duplicate LED/capacitor fabrication generators while preserving imported/custom artwork.

For example, a polarized capacitor using 0805 resolves to cap0805_polarized; an 0805 LED resolves to diode0805; a generic chip using sod123 resolves to sod123_nonpolarized, while soic8 remains soic8.

Validation:

• 38 focused tests across 33 files pass, covering footprint resolution, PCB/CAD parity, diode/LED behavior, capacitor polarity, terminal conflicts, geometry, and class exports.
• TypeScript check, package build, distribution smoke tests, formatting, and git diff --check pass.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
tscircuit-core-benchmarks	Ready	Preview	Oct 29, 2026 12:04pm UTC

[seveibar]

revising my review- not sure about this- seems like fabrication notes could be handled by footprinter

[seveibar]

see comments

[seveibar]

I have concerns