Repository navigation
fix(trace): choose shared endpoint layer for manual pcbPath routes - #4940
Open
huangji6693-max wants to merge 1 commit into
Open
huangji6693-max wants to merge 1 commit into
huangji6693-max wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a manual
pcbPath(orpcbPaths) starts on a multi-layer port (such as a plated hole spanning["top", "bottom"]) and connects without an intermediate via to a port constrained to a specific layer (such as a via's.bottomport),Trace_doInitialPcbManualTraceRenderandgetRouteForPcbPathpreviously initializedcurrentLayerfromanchorPort.getAvailablePcbLayers()[0]("top"), ignoring the endpoint layer constraint and producing asymmetric routing depending on endpoint order.This change selects a starting layer from
anchorPort.getAvailablePcbLayers()that is shared with any constraining ports or explicit initial viafromLayerbefore the first via transition (matching the shared-layer logic already used bypcbStraightLine).Closes #3906
/claim #3906
Test Plan
tests/components/primitive-components/trace-pcb-path-shared-endpoint-layer.test.tsxverifying that a manualpcbPathbetweenJ1.pin1(plated hole) and.V1 > .bottomemits"bottom"wire segments in both directions (reverse = falseandreverse = true).trace-*pcb-path*test suites pass.Payout Wallets
0x380C97bcbcAEf29DAc2d0ba7E180F1b4A7F38fddGBYWLISGOUWQ43VQEGXX6KRGDZ3CKAFFK3JXVLXKDO5TIFJUJ3OHJYOZAyXYaA9Nf4z5fpLKY6DmubWe6D2qveMd79w8pEDNHcDw