Repository navigation
Add hole-to-hole and edge-to-hole assembly drawing dimensions - #4939
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drawing dimensions can now measure PCB mounting/plated-hole spacing and edge-to-hole offsets, as well as the same measurements between named native CAD outlines.
Anchors are optional and inferred from projected geometry. Disjoint references use centers. When one reference's bounds enclose the other, core chooses the nearest edge, restricted by
axiswhen supplied; with no axis, it chooses the nearest of all four edges. Inferred edge witnesses align with the other reference's center. ExplicitfromAnchor/toAnchoroverride inference, includingcenterfor nested or concentric outlines.PCB witnesses use finalized drill coordinates. Native references reuse existing transforms for model units, fitting, origins, rotations and layer placement. Section cuts reject removed anchors instead of moving centers. Invalid, ambiguous, out-of-selection and zero-separation references fail before any page records are inserted. PCB holes accept center anchors; folded PCB references and imported mesh/STEP feature names remain unsupported.
Reference selection and dimension math remain under
lib/utils/assembly-drawing/dimensions/, with scene-point extraction ingeometry/. Includes three visual snapshots, transform/validation/inference coverage, documentation and a built-package dimension smoke test.Validation: 87 assembly tests pass, including 18 drawing tests; typecheck, package build, browser build and dist smoke checks pass.
Uses published
@tscircuit/props@^0.0.712(props #958), with no preview dependencies.Upstream integration fix: tscircuit/tscircuit#6045 (green). Inference documentation follow-up: tscircuit/props#959 (green; no schema changes).