Skip to content

fix: route whole named nets in selected autorouting phases - #4899

Open
seveibar wants to merge 2 commits into
repro/named-net-phase-selection-20261024from
fix/named-net-phase-selection-20261024
Open

seveibar wants to merge 2 commits into
repro/named-net-phase-selection-20261024from
fix/named-net-phase-selection-20261024

Conversation

@seveibar

@seveibar seveibar commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #4898. Named-net selectors now select both the Net routing task and its port-to-net traces. A regular selector moves the whole net to the selected phase; reroute adds an extra pass while retaining its later phase. This enables early native BGA support-net fanouts before DDR routing.

Validation / benchmark effect:

  • New fixtures 3/3 pass, 9 assertions; 2.33 s total process time. Inspected successful routed PCB and phase-I/O snapshots included. The early-pass fixture leaves routing to the normal later autorouter.
  • Identical existing phase fixture set plus control: 25 pass / 3 fail on both base and head, 287 assertions, 27 files / 28 tests. One paired run: 24.54 → 23.80 s; no speedup claim.
  • Same pre-existing visual mismatches on both: emitted-paths parity (0.39%), emitted-paths cache (0.02%), event-index (0.02%). No unrelated snapshot updates.
  • Solver dependencies/search unchanged; the bus-lanes 11-case benchmark is unaffected by this planner-only change.
  • Full local typecheck is limited by the reused older dependency tree (missing CircuitJSON fields/types and isolated JLCPCB type resolution). No errors reference the modified planner/new tests; clean CI remains required.

AGENTS.md now requires benchmark-effect evidence and an inspected routed snapshot for routing PRs before merge.

Successfully routed early-selected net

Clean CI on 24074189: full Bun Test matrix, Smoke Test Dist, formatting, and PR package preview all pass. Full test run. Local baseline snapshot/dependency limitations above were not reproduced by the clean CI test run.

@vercel

vercel Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Oct 24, 2026 11:44pm UTC

Request Review

@seveibar seveibar closed this Oct 24, 2026
@seveibar seveibar reopened this Oct 24, 2026
…thub.com/tscircuit/core into fix/named-net-phase-selection-20261024

# Conflicts:
#	tests/features/autoroutingphase-named-net-control.test.tsx
#	tests/features/autoroutingphase-named-net-selection.test.tsx

This branch was successfully deployed

1 active deployment
Preview — 24074189 Deployed Oct 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant