Repository navigation
repro: encoder silkscreen circles ignore inherited visibility - #4896
Draft
KrishnaX12 wants to merge 1 commit into
Draft
KrishnaX12 wants to merge 1 commit into
KrishnaX12 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
pcbSx={{ "& silkscreencircle": { visibility: "hidden" } }}on a chip still emits its circles in Circuit JSON.This small TSX fixture uses the three shaft circles and reference label from USB-C control dial v0.0.3. It compares default visibility with inherited hidden visibility. The style resolves to
hidden, but all three circles remain; both reference labels are preserved.One test and one PCB snapshot; no production changes. The fixture contains only the encoder markings, not the full board.
Validation: the repro passes with the checked-in snapshot, and TypeScript and formatting pass.