Repository navigation
feat(board): support explicit jlcpcbStackup construction selection (#4890) - #4892
Open
Brayaniglesias08 wants to merge 1 commit into
Open
Brayaniglesias08 wants to merge 1 commit into
Brayaniglesias08 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Brayaniglesias08
force-pushed
the
fix/issue-4890-jlc-stackup-construction
branch
from
October 24, 2026 17:16
0e366ed to
21e36c9
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows
<board />to explicitly select a named JLCPCB physical stackup construction viajlcpcbStackup(e.g.jlcpcbStackup="JLC04101H-3313") when multiple JLCPCB constructions share the same(num_layers, thickness, material)combination (such as 4-layer 1.0 mm FR-4:JLC04101H-1080,JLC04101H-2116,JLC04101H-3313, andJLC04101H-7628).Boardprops and JSXTscircuitElements["board"]with optionaljlcpcbStackup?: string.jlcStackupsinBoard_doInitialPcbStackupRender, verifying that itsnum_layers,thickness, andmaterialmatch the board.getJlcStackup(...)resolution whenjlcpcbStackupis omitted (so existing 4-layer 1.6 mm and 8-layer 1.4 mmfabricatorPreset="jlcpcb_standard"boards continue to work without regression) and keeps importedpcb_stackupprecedence unchanged.board-stackup-preset5..8.test.tsxandboard-stackup-unsupported6.test.tsx) for all four 4-layer 1.0 mm FR-4 constructions and mismatched stackup rejection.Closes #4890