Repository navigation
Add assembly drawing pages with relative part-view placement - #4841
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
<assembly.drawing.page>,<assembly.drawing.partview>, and<assembly.drawing.titleblock>with standard/custom paper sizes, scoped geometry selection, camera directions, sections, and relative viewport placement. Drawing placement does not move physical geometry.The visual examples reuse the reference-surface desk lamp: its mounted stepped base, hollow stem, bulb, tapered shade, support ribs, and collar. The A3 general-arrangement sheet aligns top/front/right elevations and an assembled isometric. Separate sheets show the shade's actual central section with hatching, the base's orthographic views, and a carrier board with mounting and header drills. Complete preliminary title blocks and clear label spacing replace the block examples and diagnostic sheet titles. Validation-only cases no longer produce a contrived drawing snapshot.
The test-only exporter now uses
https://jscdn.tscircuit.com/@tscircuit/circuit-json-to-drawing/0.0.2.tgz, replacing the Git commit pin. Snapshots use 4 pixels/mm and 2x supersampling. Fixed scene selection to retain standalone PCB geometry owned by the selected subcircuit, including holes omitted by component-only subtree traversal.leftOfRef,rightOfRef,aboveRef, andbelowRefresolve sibling references, including forward declarations, unequal viewports, and independent axes. Invalid nesting, missing/ambiguous selections, self-references, and same-axis cycles fail before drawing records are inserted. Props remain immutable.Validation: the previous head passed every CI test shard, typecheck, formatting, package preview and distribution smoke test. After merging current main and updating published props, Circuit JSON, Fiber and planner dependency minimums, refreshed CI is running. The drawing exporter remains on its released jscdn 0.0.2 package, which covers these page/view snapshots.
These are preliminary arrangement/inspection drawings:
FITis automatic viewport fitting; dimensioning and tolerances are not yet provided by the API.