Skip to content

Add assembly drawing pages with relative part-view placement - #4841

Merged
seveibar merged 4 commits into
mainfrom
feat/assembly-drawing-pages
Oct 26, 2026
Merged

seveibar merged 4 commits into
mainfrom
feat/assembly-drawing-pages

Conversation

@seveibar

@seveibar seveibar commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Implements <assembly.drawing.page>, <assembly.drawing.partview>, and <assembly.drawing.titleblock> with standard/custom paper sizes, scoped geometry selection, camera directions, sections, and relative viewport placement. Drawing placement does not move physical geometry.

The visual examples reuse the reference-surface desk lamp: its mounted stepped base, hollow stem, bulb, tapered shade, support ribs, and collar. The A3 general-arrangement sheet aligns top/front/right elevations and an assembled isometric. Separate sheets show the shade's actual central section with hatching, the base's orthographic views, and a carrier board with mounting and header drills. Complete preliminary title blocks and clear label spacing replace the block examples and diagnostic sheet titles. Validation-only cases no longer produce a contrived drawing snapshot.

The test-only exporter now uses https://jscdn.tscircuit.com/@tscircuit/circuit-json-to-drawing/0.0.2.tgz, replacing the Git commit pin. Snapshots use 4 pixels/mm and 2x supersampling. Fixed scene selection to retain standalone PCB geometry owned by the selected subcircuit, including holes omitted by component-only subtree traversal.

leftOfRef, rightOfRef, aboveRef, and belowRef resolve sibling references, including forward declarations, unequal viewports, and independent axes. Invalid nesting, missing/ambiguous selections, self-references, and same-axis cycles fail before drawing records are inserted. Props remain immutable.

Validation: the previous head passed every CI test shard, typecheck, formatting, package preview and distribution smoke test. After merging current main and updating published props, Circuit JSON, Fiber and planner dependency minimums, refreshed CI is running. The drawing exporter remains on its released jscdn 0.0.2 package, which covers these page/view snapshots.

These are preliminary arrangement/inspection drawings: FIT is automatic viewport fitting; dimensioning and tolerances are not yet provided by the API.

Desk lamp general arrangement

Lamp shade section

@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Oct 26, 2026 10:10pm UTC

Request Review

@seveibar
seveibar merged commit cd71de4 into main Oct 26, 2026
19 checks passed
@seveibar
seveibar deleted the feat/assembly-drawing-pages branch October 26, 2026 22:28
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


This branch was successfully deployed

1 active deployment
Preview — af3110b4 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants