Repository navigation
feat: honor noSolderPaste on SMT pads and bump props - #4636
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed test/probe pads can now use
<smtpad noSolderPaste />to omitpcb_solder_pastewhile keeping copper exposed. The shared paste creation check handles all six pad shapes, including polygons and pads inside footprints, on either layer. Omitted or explicitfalsepreserves existing behavior, covered pads still emit no paste, andtruetakes precedence oversolderPasteMargin.Bumps
@tscircuit/propsand its override from^0.0.701to^0.0.703, which includes tscircuit/props#938.Fixes #4630.
Adds a labeled PCB snapshot and a 72-pad regression matrix covering all six shapes on both layers, omitted/false/true values, margin precedence, and covered pads. Assertions check the emitted paste records and preservation of copper, mask coverage, and mask margins.
Validation:
tsc --noEmit,bun run build, distribution smoke tests, and formatting pass.Dependency availability: confirmed that the published
@tscircuit/props@0.0.703installs successfully; all 23 focused tests also pass against the npm release.