Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a speculative core implementation of
assembly.explosion.stageandassembly.explosion.move, plus a PoppyGL-rendered example that lifts an intact constrained cover, moves it aside, and then removes its cap in the displaced subassembly frame.Approval required: this is a draft experiment. Do not merge this stack before API and implementation approval.
Dependencies:
The branch pins both PR previews so it can be installed and rendered today. Core's existing dependency-check deliberately blocks merging preview dependencies; after approval, release the upstream packages and replace these pins. That merge gate is preserved.
getAssemblyExplosion(circuit, { throughStageRef?, stageProgress? })derives an immutable CAD view after normal assembly mounting constraints resolve. Stages use a stable topological sort with authored order as the fallback; references, cycles, duplicate stages, and invalid move targets produce named diagnostics. Parent movement carries descendant CAD and reference-surface centers. Repeated evaluation and backward scrubbing do not modify the assembled circuit or input props.The render tests verify upright, inverted, and tilted mount frames against emitted reference directions, and guide endpoints against emitted GLTF node translations. Run
bun scripts/render-assembly-explosion.tsx work/assembly-explosion-previewto export all four PNG/GLB/JSON states.Limitations are explicit: this prototype supports mechanical CAD translations and rejects PCB/cable-containing targets. Swept-path collision verification is not implemented; returned views report
collisionCheckStatus: "not_implemented". The diagrams do not certify assembly clearance.Approval tracking and behavior are documented in
docs/assembly-explosion.md.Validation:
tsc --noEmit: passed.git diff --checkpasses.