Repository navigation
fix: preserve SMT pad solder mask settings during Circuit JSON import - #4973
Open
rushabhcodes wants to merge 2 commits into
Open
rushabhcodes wants to merge 2 commits into
rushabhcodes wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
rushabhcodes
force-pushed
the
fix/smtpad-mask-round-trip
branch
from
October 28, 2026 03:43
1c81bd6 to
4430cfe
Compare
rushabhcodes
changed the base branch from
main
to
repro/smtpad-mask-round-trip
October 28, 2026 03:43
rushabhcodes
force-pushed
the
fix/smtpad-mask-round-trip
branch
from
October 28, 2026 04:03
4430cfe to
7638d13
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving and importing a board now preserves SMT pad solder-mask coverage and explicit margins. Core's
ANT1PCB antenna keeps its automatically generated 0.8 × 0.8 mm feed pad masked; Gerber export stays at zero openings after import.Forward
is_covered_with_solder_maskandsoldermask_margininto the rectangle, circle, pill, rotated-pill and rotated-rectangle constructors. The polygon branch already preserves them. The production change is ten lines.This PR builds on #4972 in native GitHub stack #4976 and changes only the importer and one antenna-board snapshot. The numeric regression still covers all six pad shapes on both layers, positive/zero/negative margins, omitted defaults, and saved-JSON immutability.
Validation: seven focused antenna/mask tests,
tsc --noEmit, formatting, andgit diff --checkpass. Gerber validation confirms the antenna stays at zero openings; native rectangle/circle cases preserve coverage, signed/zero margins and aperture dimensions.The single updated snapshot shows the imported antenna with its feed pad still masked. The faulty version is in #4972.