Repository navigation
Reproduce tiny trace drill failure with visual baseline - #2
Merged
Merged
Conversation
seveibar
changed the title
Collaborator
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reduced smart-ring trace and SVG/PNG snapshots showing the input copper envelope alongside the actual conversion failure. The 1.7 nm route segment causes a FlattenJS boundary conflict during via drill subtraction. This PR establishes the unfixed baseline; a stacked follow-up restores the fix and updates the same snapshots so its Files changed view shows the visual difference. Both reproduction and visual tests pass against the baseline behavior.
Stacked fix and before/after image diff: #3. Merge this baseline first, then #3.