FEM capabilities in the problem/data classes - #115
Draft
acdanila wants to merge 15 commits into
Draft
Conversation
ccuetom
reviewed
Aug 14, 2026
ccuetom
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Please, add the testing call to the GitHub actions so they are triggered when needed. If testing dolphinx is required, then that should also be installed in the actions (maybe through the optional requirements or some other requirements file?)
Author
|
@ccuetom, dealing with the envs and adding dolfinx will require a bit more thought, I don't have a clear solution as of now, but I'm sure a clean one exists. dolfinx and some other packages need to be included into the environment.yml file to be used by conda. for now, I've added a pytest gh action that doesn't use dolfinx, so 3 of the tests are skipped |
…bility and env.yaml files for dolfinx builds
ccuetom
reviewed
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.