Skip to content

FEM capabilities in the problem/data classes - #115

Draft
acdanila wants to merge 15 commits into
masterfrom
fem_implementation
Draft

FEM capabilities in the problem/data classes#115
acdanila wants to merge 15 commits into
masterfrom
fem_implementation

Conversation

@acdanila

@acdanila acdanila commented Aug 3, 2026

Copy link
Copy Markdown

No description provided.

@acdanila
acdanila requested review from ccuetom and danisw7 August 3, 2026 09:23
@acdanila acdanila changed the title skeleton FEM capabilities in the problem classes Aug 4, 2026
@acdanila acdanila changed the title FEM capabilities in the problem classes FEM capabilities in the problem/data classes Aug 13, 2026

@ccuetom ccuetom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please, add the testing call to the GitHub actions so they are triggered when needed. If testing dolphinx is required, then that should also be installed in the actions (maybe through the optional requirements or some other requirements file?)

Comment thread stride/problem/data.py Outdated
Comment thread stride/problem/data.py Outdated
Comment thread stride/problem/data.py
Comment thread stride/problem/data.py Outdated
Comment thread stride/problem/domain.py
Comment thread stride/tests/test_meshed_data.py Outdated
Comment thread stride/tests/test_meshed_data.py Outdated
Comment thread stride/tests/test_meshed_medium.py Outdated
Comment thread stride/tests/test_meshed_medium.py Outdated
Comment thread stride/tests/test_meshed_space.py Outdated
@acdanila

Copy link
Copy Markdown
Author

@ccuetom, dealing with the envs and adding dolfinx will require a bit more thought, I don't have a clear solution as of now, but I'm sure a clean one exists. dolfinx and some other packages need to be included into the environment.yml file to be used by conda.

for now, I've added a pytest gh action that doesn't use dolfinx, so 3 of the tests are skipped

Comment thread .github/workflows/pytest.yml
Comment thread environment-fem-complex.yml Outdated
Comment thread environment-fem-real.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants