Repository navigation
Conversation
mvz
force-pushed
the
issue-1369-remove-deprecated
branch
from
August 16, 2026 08:40
fc5c0a2 to
3e6b1fb
Compare
mvz
marked this pull request as ready for review
August 16, 2026 08:40
Collaborator
Author
|
Remove code, coverage drops !? |
mvz
force-pushed
the
issue-1369-remove-deprecated
branch
from
August 16, 2026 08:51
3e6b1fb to
5646c24
Compare
Collaborator
Author
|
Ah, there were some leftover methods in this commit. I have pushed an updated commit. The coverage is still down a tiny bit since the total number of lines is lower but the set of uncovered lines remains the same. Funny how that works. |
Collaborator
Author
|
There are some differences between the deprecated method and its replacement, so this has to be handled a bit more carefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1369.