Repository navigation
signature: support PCR policy authorization - #187
Open
ahendre2010 wants to merge 1 commit into
Open
ahendre2010 wants to merge 1 commit into
ahendre2010 wants to merge 1 commit into
Conversation
Signed-off-by: Akshay Hendre <ahendre2010@gmail.com>
Member
|
|
Author
|
Can you please help me understand why these test might be failing? |
moritzbuhl
reviewed
Sep 29, 2026
| sctx->pkey->data.pub.publicArea.nameAlg, &session); | ||
| if (r) | ||
| goto out; | ||
| r = Esys_TRSess_SetAttributes(sctx->esys_ctx, session, |
Member
There was a problem hiding this comment.
this causes a deadlock with older OpenSSL versions, probably the way it does signature calls differs?
The hang is the first CSR call:
openssl req -provider tpm2 -provider default \
-propquery '?provider=tpm2' \
-new -subj '/CN=policy-test' \
-key "handle:${KEY_HANDLE}" \
-sigopt 'policy-pcr:sha256:0,1,7' \
-out policy-test.csr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #154.
Proposed interface:
-sigopt policy-pcr:sha256:(pcr)[,(pcr),...]
Internally tpm2-openssl provider can create TPM2_SE_POLICY session, set PCR policy before Esys sign the digest.
If maintainer agrees with approach, I can replicate this for other algorithms.