Skip to content

chore improvements on create-granite-app - #316

Open
mym0404 wants to merge 5 commits into
toss:mainfrom
mym0404:chore/soothe-lint
Open

chore improvements on create-granite-app #316
mym0404 wants to merge 5 commits into
toss:mainfrom
mym0404:chore/soothe-lint

Conversation

@mym0404

@mym0404 mym0404 commented Jun 17, 2026

Copy link
Copy Markdown

Overview

blocked by #316

I encountered these warnings from a generated shared bundle app during easygoing browsing.

image

While I was working on these fixes, I got pulled into a couple of small cleanup tasks and ended up fixing those as well.

Changes

1. path.join -> path.resolve

CLI can accept an absolute path now.

The former version rejected the absolute path due to path.join(pwd(), ...)

2. Add type import keyword for auto-generated route import statements.

  • plugin-router affected
  • bootstrap template updated

3. Remove redundant import React from the template.

Evidences (use automatic jsx transformation option)

4. Use select over multiselect when choosing linter.

  • Selecting both caused some errors.

5. lint yarn command of biome template doesn't fix code anymore

  • Aligned logic with eslint (check only).
  • Since biome check --write had been silently fixing warnings, the test had been passed for a while.

Test Plan

  • yarn workspace create-granite-app test:no-parallel

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9359f49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
create-granite-app Patch
@granite-js/plugin-router Patch
babel-preset-granite Patch
@granite-js/blur-view Patch
@granite-js/brownfield-module Patch
@granite-js/cli Patch
@granite-js/cookies Patch
@granite-js/screen Patch
@granite-js/image Patch
@granite-js/jest Patch
@granite-js/lottie Patch
@granite-js/mpack Patch
@granite-js/native Patch
@granite-js/naver-map Patch
@granite-js/plugin-core Patch
@granite-js/plugin-env Patch
@granite-js/plugin-hermes Patch
@granite-js/plugin-micro-frontend Patch
@granite-js/plugin-rozenite Patch
@granite-js/plugin-sentry Patch
@granite-js/react-native Patch
@granite-js/style-utils Patch
@granite-js/utils Patch
@granite-js/video Patch
@granite-js/vitest Patch
@granite-js/deployment-manager Patch
@granite-js/forge-cli Patch
@granite-js/pulumi-aws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

@mym0404 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant