[PF-2005] Create Code Connect config Component Library V2#5016
Conversation
|
268d14d to
f5bd3e5
Compare
| <Accordion expanded={expanded} borders={borders} content={<p>Content</p>}> | ||
| Summary | ||
| </Accordion> |
There was a problem hiding this comment.
would it make sense to have these examples similar to the stories we have for the components?
(Asking as for example here we have also Accordion.Summary and Accordion.Details)
hmmm we could even re-use the examples from stories?
There was a problem hiding this comment.
Good catch, fixed in 6674432
When it comes to Storybook examples - the issue is that in this case the code examples in Figma will look like <StorybookExampleName/> which eliminates the whole point of Code Connect
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
|
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
78685ef to
4ab6f6f
Compare
042ade3 to
30547b5
Compare
- Fix all template literal URLs (replaced ${FILE_KEY} with inlined key)
- Fix wrong node IDs pointing to variant instances instead of component sets:
Modal, Notification, Note, Timeline, Loader, Tooltip, OverviewBlock
- Fix wrong node IDs pointing to design frames instead of components:
Table (-> Table Cell), Switch (-> Switches), Stepper, PageHead, List (-> List Item)
- Fix invalid Figma property references: HelpBox Color, Tooltip Content,
EmptyState Title, QueryBuilder Loading, Input Show Error, Section/EmptyState
unsupported expression patterns
- All 95 Code Connect files now pass validation (npx figma connect publish --dry-run)
4ab6f6f to
ea4d5e1
Compare
picasso-tailwind-merge source does not import from picasso-utils. The stale dep + tsconfig reference created a false edge in the Nx task graph that caused a circular dependency, which in turn caused Nx to skip building picasso-tailwind-merge on a cold CI cache. Packages that reference picasso-tailwind-merge in their tsconfig (e.g. Typography) then failed because tsc -b could not find the tailwind-merge artifacts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
|
📖 Storybook Preview 🚀 Your Storybook preview is ready: View Storybook 📍 Preview URL: This preview is updated automatically when you push changes to this PR. |
[PF-2005](https://toptal-core.atlassian.net/browse/PF-2005?search_id=a20599ed-15c9-4f4e-bc7c-c62e5cce743d)
Description
Creating a Code Connect config for 10 Picasso components
How to test
Development checks
picasso-tailwind-mergerequires major update (check itsREADME.md)propsin component with documentationexamplesfor componentBreaking change
Alpha packages
Manually trigger the publish.yml workflow to publish alpha packages. Specify pull request number as a parameter (only digits, e.g.
123).PR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?