Skip to content

[PF-2005] Create Code Connect config Component Library V2#5016

Open
Kosov234 wants to merge 8 commits into
feature/picasso-modernization-tempfrom
pf-2005-cover-base-design-system-picasso-with-code-connect-top-20
Open

[PF-2005] Create Code Connect config Component Library V2#5016
Kosov234 wants to merge 8 commits into
feature/picasso-modernization-tempfrom
pf-2005-cover-base-design-system-picasso-with-code-connect-top-20

Conversation

@Kosov234

@Kosov234 Kosov234 commented Jun 22, 2026

Copy link
Copy Markdown

[PF-2005](https://toptal-core.atlassian.net/browse/PF-2005?search_id=a20599ed-15c9-4f4e-bc7c-c62e5cce743d)

Description

Creating a Code Connect config for 10 Picasso components

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

Alpha packages

Manually trigger the publish.yml workflow to publish alpha packages. Specify pull request number as a parameter (only digits, e.g. 123).

PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@Kosov234 Kosov234 self-assigned this Jun 22, 2026
@Kosov234 Kosov234 requested a review from a team as a code owner June 22, 2026 09:08
@Kosov234 Kosov234 added the WIP Work in Progress (Don't review) label Jun 22, 2026
@changeset-bot

changeset-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2ba6acf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Kosov234 Kosov234 changed the base branch from feature/picasso-modernization-temp to master June 22, 2026 09:10
@Kosov234 Kosov234 force-pushed the pf-2005-cover-base-design-system-picasso-with-code-connect-top-20 branch 2 times, most recently from 268d14d to f5bd3e5 Compare June 22, 2026 09:20
Comment on lines +22 to +24
<Accordion expanded={expanded} borders={borders} content={<p>Content</p>}>
Summary
</Accordion>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to have these examples similar to the stories we have for the components?
(Asking as for example here we have also Accordion.Summary and Accordion.Details)

hmmm we could even re-use the examples from stories?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in 6674432

When it comes to Storybook examples - the issue is that in this case the code examples in Figma will look like <StorybookExampleName/> which eliminates the whole point of Code Connect

@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/5016/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/5016/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫

Commit 62109fc does not meet requirements of Commit Message Quality:

  • body lines must not exceed 79 characters

Generated by 🚫 dangerJS against 2ba6acf

@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/5016/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request Jun 23, 2026
@Kosov234 Kosov234 changed the title [PF-2005] Create Code Connect config for 10 Picasso components [PF-2005] Create Code Connect config Component Library V2 Jun 24, 2026
@Kosov234 Kosov234 force-pushed the pf-2005-cover-base-design-system-picasso-with-code-connect-top-20 branch from 78685ef to 4ab6f6f Compare June 26, 2026 08:48
@Kosov234 Kosov234 changed the base branch from master to feature/picasso-modernization-temp June 26, 2026 08:48
@vedrani vedrani force-pushed the feature/picasso-modernization-temp branch from 042ade3 to 30547b5 Compare June 30, 2026 07:07
Kosov234 added 6 commits June 30, 2026 12:00
- Fix all template literal URLs (replaced ${FILE_KEY} with inlined key)
- Fix wrong node IDs pointing to variant instances instead of component sets:
  Modal, Notification, Note, Timeline, Loader, Tooltip, OverviewBlock
- Fix wrong node IDs pointing to design frames instead of components:
  Table (-> Table Cell), Switch (-> Switches), Stepper, PageHead, List (-> List Item)
- Fix invalid Figma property references: HelpBox Color, Tooltip Content,
  EmptyState Title, QueryBuilder Loading, Input Show Error, Section/EmptyState
  unsupported expression patterns
- All 95 Code Connect files now pass validation (npx figma connect publish --dry-run)
@Kosov234 Kosov234 force-pushed the pf-2005-cover-base-design-system-picasso-with-code-connect-top-20 branch from 4ab6f6f to ea4d5e1 Compare June 30, 2026 09:05
picasso-tailwind-merge source does not import from picasso-utils.
The stale dep + tsconfig reference created a false edge in the Nx task
graph that caused a circular dependency, which in turn caused Nx to skip
building picasso-tailwind-merge on a cold CI cache. Packages that
reference picasso-tailwind-merge in their tsconfig (e.g. Typography)
then failed because tsc -b could not find the tailwind-merge artifacts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/5016/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request Jun 30, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/5016/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in Progress (Don't review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants