Separate CLI and service server configs - #1257
Open
floitsch wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1256.
Summary
ServerConfighierarchy from the service-sideBrokerConfighost/port/path/use_tlsfields with complete base URLsThe CLI configuration still owns backend selection, authentication inputs, fleet scope, and the polling policy used when generating a service configuration. The generated
BrokerConfigcontains only the five operation URL templates, root certificates, optional device headers, and polling policy; it has no CLI server name, scope, backend type, or Supabase-specific state.HTTP versus HTTPS is now determined solely by each URL. There is no separate TLS flag in newly written configurations.
Compatibility
Old
supabaseandtoit-httpJSON containinghost,port,path,use_tls, and the singular Supabase certificate fields is accepted and converted in memory. Newly serialized CLI configuration usesurland the common root-certificate list.Testing
toit run --project-root tests tests/server-config-test.toittoit run --project-root tests tests/auth-provider-test.toit -- --http-servertoit run --project-root tests tests/broker-test.toit -- --http-toit-brokertoit run --project-root tests tests/broker-test.toit -- --http-toit-combined-broker