Add HTTP shared-tenancy broker variant for tests. - #1245
Open
floitsch wants to merge 3 commits into
Open
Conversation
Mirrors the BrokerCliSupabase shared-tenancy path so the HTTP test broker can exercise the cross-table auth-side write that production shared-tenancy deployments rely on. CLI: - BrokerCliHttpShared (subclass of BrokerCliHttp) overrides notify-created to send _hardware_id and _organization_id alongside _device_id/_state on the wire. - BrokerCli factory dispatches HTTP + TENANCY-SHARED to the shared variant; other HTTP configs keep the dedicated path. Shared config: - ServerConfigHttp gains a 'with --tenancy/string' clone, matching the Supabase variant. HTTP test broker server: - Stores auth-side device records in auth-devices_ when notify-created carries the extra fields. Rejects duplicate hardware-ids. - Exposes get-auth-device + insert-auth-device for the backdoor. Tests: - with-broker recognizes 'http-toit-shared'; with-http-broker takes an optional --tenancy to opt into shared mode. - ToitHttpBackdoor carries the scoped ServerConfigHttp and mirrors the shared-tenancy auth-side insert in its create-device backdoor. - broker-test.toit asserts auth-side records are populated when running under http-toit-shared. - CMakeLists.txt adds --http-toit-shared-broker to BROKER_FLAGS so all BROKER tests exercise the shared HTTP variant.
Replace the three separate 'with --host', 'with --scope', 'with --tenancy' overloads (per subclass) with a single 'with' that takes all updatable fields as optional. Non-null params override 'this.field', null params inherit it. Matches the FleetFile.with pattern already used elsewhere in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared-tenancy HTTP broker path and exercises the auth-side device creation now owned by brokers.\n\nCLI:\n- BrokerCliHttpShared overrides notify-created to send hardware-id and organization-id alongside device-id and state.\n- The BrokerCli factory selects the shared HTTP variant when the server config uses shared tenancy; dedicated HTTP configs keep the existing path.\n\nShared config:\n- ServerConfig.with is a single clone method with optional host, scope, and tenancy overrides.\n- Both Supabase and HTTP configs preserve fields that are not overridden.\n\nHTTP test broker:\n- Stores auth-side device records when notify-created carries the shared-tenancy fields.\n- Validates hardware-id and organization-id as a pair.\n- Performs duplicate and payload validation before mutating broker or auth-side state.\n- Exposes auth-record lookup and insertion to the test backdoor.\n\nTests:\n- Adds http-toit-shared to the broker test matrix.\n- Removes the stale Supabase auth-device pre-seeding, so notify-created is responsible for creating the record under test.\n- Verifies the broker-created hardware-id record contains both the expected alias and organization-id for shared HTTP and shared Supabase.\n- Keeps the Artemis Supabase resource lock while shared broker tests inspect auth-side records.