Update fuzz tests plus minor fixes - #428
Merged
Merged
Conversation
Decided to make ReadArray always stop after an error. There is a too high risk of running into an infinite loop. Added size checks for (Writer.)WriteBytes/WriteString/WriteStringFromBytes Add panic recovery to binary marshal helpers.
Member
|
IMO we shouldn't be recovering from panics we don't throw ourselves. |
philhofer
reviewed
Dec 4, 2025
gannett-ggreer
pushed a commit
to GannettDigital/msgp
that referenced
this pull request
Aug 25, 2026
Decided to make ReadArray always stop after an error. There is a too high risk of running into an infinite loop. Added size checks for (Writer.)WriteBytes/WriteString/WriteStringFromBytes Add panic recovery to binary marshal helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to make ReadArray always stop after an error. There is a too high risk of running into an infinite loop.
Added size checks for (Writer.)WriteBytes/WriteString/WriteStringFromBytes
Add panic recovery to binary marshal helpers.