encoders: add missing ESP32, ESP32-S3, and ESP32-C6 targets to the build constraint - #893
Open
pottekkat wants to merge 1 commit into
Open
encoders: add missing ESP32, ESP32-S3, and ESP32-C6 targets to the build constraint#893pottekkat wants to merge 1 commit into
pottekkat wants to merge 1 commit into
Conversation
pottekkat
force-pushed
the
esp32-build-constraint
branch
from
September 10, 2026 15:30
95b1d3d to
a189beb
Compare
pottekkat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
The build constraint in
encoders/quadrature_interrupt.goleft outesp32,esp32s3, andesp32c6, although all three definemachine.PinToggle.https://github.com/tinygo-org/tinygo/blob/02021b5853f39750fd0c12c92be2f3e09a9352ac/src/machine/machine_esp32.go#L366-L370
https://github.com/tinygo-org/tinygo/blob/02021b5853f39750fd0c12c92be2f3e09a9352ac/src/machine/machine_esp32s3.go#L319-L323
https://github.com/tinygo-org/tinygo/blob/02021b5853f39750fd0c12c92be2f3e09a9352ac/src/machine/machine_esp32c6.go#L80-L84