feat(gap): add ConnectionPriority to ConnectionParams - #471
Closed
acouvreur wants to merge 1 commit into
Closed
Conversation
Not every platform accepts the connection parameters from the Core Specification. Some only accept a small fixed set of presets: on Windows, BluetoothLEPreferredConnectionParameters has no public constructor, just the static ThroughputOptimized, Balanced and PowerOptimized sets. ConnectionPriority is the form of the request those platforms can honour. The constants are named after the trade-off rather than the resulting latency because the vendor enumerations disagree on a direction: Apple's CBPeripheralManagerConnectionLatency .low and Android's CONNECTION_PRIORITY_HIGH mean the same thing, so Low/Medium/High would be read backwards by half of the audience. It also keeps "connection latency" free for the numeric parameter the Core Specification uses it for, which is the number of connection events a peripheral may skip. The zero value means "leave the connection unchanged", matching the other ConnectionParams fields. No backend reads Priority yet; wiring up the platforms that can honour it follows separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
I opened this again as #472, from a branch in this repository. A PR that is on top of this one cannot use a branch in my fork as its base. The content is the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed. This work is now #472, from a branch in this repository.