*: revert gRPC stream operation duration metrics (#11048) - #11049
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3b76282 to
e32c1cc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
close tikv#11040\n\nRevert the gRPC stream operation duration metrics introduced in tikv#10254 and the dependent Grafana stream-send panels from tikv#10339. This removes `grpcutil.MetricsStream` and the peer-IP-labeled `grpc_stream_operation_duration_seconds` histograms from PD and MCS services, eliminating the unbounded cardinality leak until a safer replacement lands.\n\nSigned-off-by: JmPotato <github@ipotato.me> (cherry picked from commit 070828c) Signed-off-by: JmPotato <github@ipotato.me>
e32c1cc to
026367b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-202603 #11049 +/- ##
==========================================================
- Coverage 79.19% 79.16% -0.04%
==========================================================
Files 532 530 -2
Lines 72818 72726 -92
==========================================================
- Hits 57668 57570 -98
- Misses 11114 11122 +8
+ Partials 4036 4034 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/retest |
|
/test pull-unit-test-next-gen-2 |
8b6739b
into
tikv:release-nextgen-202603
This is an automated cherry-pick of #11048
What problem does this PR solve?
Issue Number: close #11040
grpcutil.NewMetricsStreamregisters histogram children labeled by peer IP with no lifecycle cleanup. Long-running PD/MCS processes accumulate unbounded label series (observed ~840k series from ~18k historical IPs), inflating memory and/metricsscrape cost until scrapes fail.What is changed and how does it work?
Check List
Tests
Related changes
Release note
Summary by CodeRabbit