Skip to content

PD: fix alert description by removing incorrect type label - #11046

Open
max-melentyev wants to merge 1 commit into
tikv:masterfrom
max-melentyev:patch-1
Open

PD: fix alert description by removing incorrect type label#11046
max-melentyev wants to merge 1 commit into
tikv:masterfrom
max-melentyev:patch-1

Conversation

@max-melentyev

@max-melentyev max-melentyev commented Jul 23, 2026

Copy link
Copy Markdown

What problem does this PR solve?

Fixes incorrect alert description

PD: fix alert description by removing incorrect `type` label

Check List

Tests

[X] No code

Release note

PD: fix alert description by removing incorrect `type` label

Summary by CodeRabbit

  • Bug Fixes
    • Improved alert descriptions by removing an outdated label reference and standardizing value formatting.
    • Updated alert configuration formatting while preserving the existing displayed summary.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. contribution This PR is from a community contributor. dco-signoff: no Indicates the PR's author has not signed dco. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Hi @max-melentyev. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Welcome @max-melentyev!

It looks like this is your first PR to tikv/pd 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/pd. 😃

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3a4ea10-2e04-4cc4-b0f8-d169cc8bf869

📥 Commits

Reviewing files that changed from the base of the PR and between 0087e3b and b4d217e.

📒 Files selected for processing (1)
  • metrics/alertmanager/pd.rules.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • metrics/alertmanager/pd.rules.yml

📝 Walkthrough

Walkthrough

Two alert annotations in metrics/alertmanager/pd.rules.yml were updated: one removes a label reference and adjusts interpolation spacing, while the other changes YAML formatting without changing displayed text.

Changes

Alert rule annotations

Layer / File(s) Summary
Annotation formatting updates
metrics/alertmanager/pd.rules.yml
The store space alert description no longer references the type label and adjusts values spacing; the etcd quota summary line was reformatted while retaining its text.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing required template sections, including Issue Number and the 'What is changed and how does it work?' section. Add the missing template sections, especially an Issue Number line, a change summary, side effects, related changes, and a complete release note if needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: fixing an alert description by removing the incorrect type label.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 24, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-07-24 02:53:50.546171022 +0000 UTC m=+1546216.582266079: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 24, 2026
@rleungx

rleungx commented Jul 24, 2026

Copy link
Copy Markdown
Member

/retest

Signed-off-by: Max Melentyev <max.melentyev@reddit.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jul 24, 2026
@max-melentyev

Copy link
Copy Markdown
Author

force-pushed a commit with Signed-off-by

@ti-chi-bot

ti-chi-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

@max-melentyev

Copy link
Copy Markdown
Author

Hi @rleungx , thanks for the review. I've re-pushed the commit with sign-off added. Could you please unblock tests?

@rleungx

rleungx commented Jul 27, 2026

Copy link
Copy Markdown
Member

/retest

@rleungx

rleungx commented Jul 27, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.23%. Comparing base (39b6220) to head (b4d217e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11046      +/-   ##
==========================================
- Coverage   79.25%   79.23%   -0.02%     
==========================================
  Files         541      540       -1     
  Lines       76037    76010      -27     
==========================================
- Hits        60262    60229      -33     
+ Misses      11534    11527       -7     
- Partials     4241     4254      +13     
Flag Coverage Δ
unittests 79.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx

rleungx commented Jul 27, 2026

Copy link
Copy Markdown
Member

/retest

@ti-chi-bot

ti-chi-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@max-melentyev: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-3 b4d217e link true /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants