build(ecdsa): remove obsolete Waffle toolchain

[mswilkison]

Summary

• remove @nomiclabs/hardhat-waffle and ethereum-waffle from the ECDSA package, which already registers @nomicfoundation/hardhat-chai-matchers
• replace the remaining waffle.provider usages with ethers.provider and rely on the globally registered Hardhat matchers
• migrate the affected custom-error assertions and fund the mocked staking sender used by the backward-compatibility test
• prune the obsolete Waffle, Ganache, and transitive dependency subtree from both lockfiles

Issue #3992 proposed upgrading Waffle, but @nomiclabs/hardhat-waffle cannot coexist with the already-loaded @nomicfoundation/hardhat-chai-matchers plugin. Removing the redundant Waffle stack completes the migration without retaining two competing Chai integrations.

Validation

• yarn install --immutable
• npm run build
• npm run lint (passes with pre-existing warnings)
• npm test — 650 passing, 44 pending
• npm run deploy:test

The npm lockfile removes 1,019 package entries, adds none, and leaves every surviving package entry unchanged apart from the root dependency list. The Yarn lockfile removes 382 resolution locators and adds or upgrades none.

Lockfile overlap

Open PRs #4108, #4025, and #3904 also touch the ECDSA lockfiles and may need regeneration or a rebase after this lands. This PR intentionally includes none of their package upgrades.

Fixes #3992

[coderabbitai]

Warning

Review limit reached

@mswilkison, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 08edb9c8-db18-4f55-91ac-7ad8ac343f56

📥 Commits

Reviewing files that changed from the base of the PR and between 038b7ce and 8d281a8.

⛔ Files ignored due to path filters (2)

• solidity/ecdsa/package-lock.json is excluded by !**/package-lock.json
• solidity/ecdsa/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (9)

• solidity/ecdsa/hardhat.config.ts
• solidity/ecdsa/package.json
• solidity/ecdsa/test/Allowlist.test.ts
• solidity/ecdsa/test/WalletRegistry.DualMode.test.ts
• solidity/ecdsa/test/WalletRegistry.Inactivity.test.ts
• solidity/ecdsa/test/WalletRegistry.WalletCreation.test.ts
• solidity/ecdsa/test/helpers/gas.ts
• solidity/ecdsa/test/utils/dkg.ts
• solidity/ecdsa/types/chai.d.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ecdsa-remove-waffle

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}