fix(tbtc): keep FROST activation wallets signable#4152
Merged
mswilkison merged 1 commit intoJul 13, 2026
Merged
Conversation
Preserve persisted legacy tECDSA shares on the legacy bridge in the cgo FROST build, require the complete interactive ROAST path before starting distributed DKG, and start ROAST receiving only after the first subscriber exists.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
merged commit Jul 13, 2026
f08e8d1
into
feat/frost-schnorr-migration-scaffold
18 checks passed
mswilkison
added a commit
that referenced
this pull request
Jul 13, 2026
Stack: 2/2, based on #4152 (which is based on #3866). Addresses both fee-estimation findings from the activation review: - redemption proposals resolve the wallet's canonical script and size the main input and change output with the P2TR shape for FROST wallets; - moved-funds sweep proposals resolve the actual moved-funds prevout plus the target wallet output script, including the optional main-UTXO input. The existing exported estimators remain available as legacy P2WPKH compatibility wrappers. New script-aware variants cover P2TR callers. Regression tests pin the one-vbyte differences: 251 vs 250 vB for redemption and 111 vs 110 vB for a fresh moved-funds sweep. They also cover two-input sweeps, fee caps, proposal wiring, and legacy compatibility. Verified with go test for pkg/tbtcpg under default and frost_native builds, plus go vet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 1/2, based on #3866. Downstream: #4153.
Addresses the runtime-safety findings from the activation review:
Regression coverage includes a persisted legacy signer round trip, missing ROAST env/build gates, synchronous receive-on-subscribe delivery, and the full activation build-tag selection.
Verified with default, frost_native, frost_native+frost_roast_retry, frost_native+frost_tbtc_signer, and full activation-tag focused suites, plus the runner-bus race test.