Repository navigation
Resolve the Capybara session when the audit runs - #39
Merged
Merged
Conversation
seanpdoyle
approved these changes
Sep 22, 2026
Contributor
Author
|
@seanpdoyle I've pushed 14a40a1 but looks like some of the failures/flakes are on main already? Should I keep trying to fix this? |
Contributor
|
@MatheusRich I've merged #42 to pass CI on |
MatheusRich
force-pushed
the
resolve-session-at-audit-time
branch
from
September 22, 2026 20:34
14a40a1 to
e56a7a5
Compare
seanpdoyle
approved these changes
Sep 22, 2026
Comment on lines
+35
to
+37
| # Chrome sometimes needs more than Ferrum's 10-second default to boot | ||
| # on a shared runner. | ||
| FERRUM_PROCESS_TIMEOUT: "30" |
Contributor
There was a problem hiding this comment.
This was part of a previous PR, and can be omitted.
Suggested change
| # Chrome sometimes needs more than Ferrum's 10-second default to boot | |
| # on a shared runner. | |
| FERRUM_PROCESS_TIMEOUT: "30" |
MatheusRich
force-pushed
the
resolve-session-at-audit-time
branch
from
September 22, 2026 21:22
e56a7a5 to
9448c0a
Compare
seanpdoyle
reviewed
Sep 23, 2026
Contributor
There was a problem hiding this comment.
Is this coverage possible to achieve from a Minitest System Test? The presence of the RSpec suite is solely for the purpose of exercising the RSpec-facing public interface of the gem.
The rest of the internal test suite is written in Minitest.
Contributor
Author
There was a problem hiding this comment.
I've added a minitest test, but kept this one to also test the RSpec hook ordering thing. LMK if you think this is unnecessary.
MatheusRich
force-pushed
the
resolve-session-at-audit-time
branch
from
September 23, 2026 14:29
9448c0a to
74fa47d
Compare
seanpdoyle
approved these changes
Sep 23, 2026
The engine builds the auditor inside a `before` hook. It passes the session that is current at that moment. A host suite can select its driver with `driven_by` from a `before` hook of its own. That hook registers later, so it runs later. The auditor then holds the default `:rack_test` session while the example runs against a real browser. Every audit fails with `Capybara::NotSupportedByDriverError` on the first `visit`. This commit passes the test to the auditor instead of the session. The auditor asks the test for `page` when it audits, so it always uses the session that is current at that moment. The reporters already receive the test, so the two constructor arguments now match. The new spec calls `driven_by` from a plain `before` hook. It fails on `main` with the error above and passes with this change. The new test visits a page inside `using_session`. On `main`, the auditor audits the blank page of the first session, so the test fails. It passes with this change.
MatheusRich
force-pushed
the
resolve-session-at-audit-time
branch
from
September 23, 2026 17:55
74fa47d to
5e6cfba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine builds the auditor inside a
beforehook. It passes the session that is current at that moment. A host suite can select its driver withdriven_byfrom abeforehook of its own. That hook registers later, so it runs later. The auditor then holds the default:rack_testsession while the example runs against a real browser. Every audit fails withCapybara::NotSupportedByDriverErroron the firstvisit.This PR passes the test to the auditor instead of the session. The auditor asks the test for
pagewhen it audits, so it always uses the session that is current at that moment. The reporters already receive the test, so the two constructor arguments now match.The new spec calls
driven_byfrom a plainbeforehook. It fails onmainwith the error above and passes with this change.