Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Show Minutes and Seconds in Cutoff - #462

Merged
FinnIckler merged 4 commits into
mainfrom
fix/cutoffs
Apr 2, 2024
Merged

Show Minutes and Seconds in Cutoff#462
FinnIckler merged 4 commits into
mainfrom
fix/cutoffs

Conversation

@FinnIckler

@FinnIckler FinnIckler commented Feb 16, 2024

Copy link
Copy Markdown
Member

No description provided.

gregorbg
gregorbg reviewed Feb 16, 2024
View reviewed changes
Comment thread Frontend/src/pages/events/index.jsx Outdated
@FinnIckler

FinnIckler commented Feb 17, 2024

Copy link
Copy Markdown
Member Author

We currently do not have a strategy in place for sharing code. I would think an npm package using typescript would be the best idea.

@gregorbg

gregorbg commented Feb 17, 2024

Copy link
Copy Markdown
Member

We currently do not have a strategy in place for sharing code. I would think an npm package using typescript would be the best idea.

What about https://github.com/thewca/wca-helpers?

gregorbg
gregorbg reviewed Feb 17, 2024
View reviewed changes

@gregorbg gregorbg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay, but does this consider 333fm and 333mbld correctly?

@FinnIckler

FinnIckler commented Feb 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

It does not. I'll add it now

@FinnIckler

FinnIckler commented Feb 18, 2024

Copy link
Copy Markdown
Member Author

There is actually already a format centisecond method in wca-helpers https://github.com/thewca/wca-helpers/blob/master/src/helpers/time.ts, but it doesn't include the string.
I'll add a PR that adds these options and includes the other methods

@FinnIckler

FinnIckler commented Feb 19, 2024

Copy link
Copy Markdown
Member Author

That's done thewca/wca-helpers#30

@FinnIckler

FinnIckler commented Apr 2, 2024

Copy link
Copy Markdown
Member Author

I'm going to merge this for now and then just make another PR when we update wca-helpers

@FinnIckler
FinnIckler merged commit a1b5702 into main Apr 2, 2024
@FinnIckler
FinnIckler deleted the fix/cutoffs branch April 2, 2024 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gregorbg gregorbg gregorbg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FinnIckler @gregorbg