allow sorting results table by solve attempt columns - #308
Open
Victus0660 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, WCA Live displays round results strictly by official ranking. However, in events like FMC (3x3x3 Fewest Moves), competitors who DNF their overall mean often have impressive single attempts that get buried in the list. Allowing users to sort by individual solve attempt columns makes it easy to see the best scores for each attempt and analyze performance per solve.
Summary of Changes
sortResultsByColumn()inclient/src/lib/result.jsto sort by attempt index or stat column while properly prioritizing valid attempts over incomplete (DNF/DNS/skipped) entries.<TableSortLabel>into attempt headers (1,2,3, etc.) and stat headers (Best,Average/Mean) inRoundResultsTable.jsx.RoundResults.jsxwith a 3-step click cycle (Ascending -> Descending -> Reset to official server order).#column so users can easily reference official placements while sorting.sortResultsByColumn()inclient/src/lib/tests/result.test.js.Verification