[improve][ci] Check formatting in CI

[thep2p]

No description provided.

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Adds Rust formatting validation to the CI lint job.

Changes:

• Runs make format during CI.

File	Description
.github/​workflows/​rust.yml	Adds the formatting validation step.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[thep2p]

@claude review

[github-actions]

Claude finished @thep2p's task —— View job

---

Code Review: PR #150 — Check formatting in CI

• Read changed files
• Analyze CI workflow change
• Analyze base_node.rs change
• Post review

---

Verdict: Approve ✅ — small, correct, and well-scoped change.

What this does

• Adds a Check Format step to the lint job in .github/workflows/rust.yml:36-37, running make format.
• make format maps to cargo fmt --all -- --check (Makefile:25-28), which is the right choice for CI: it's non-mutating and exits non-zero on unformatted code, so a violation fails the build instead of silently rewriting files.
• The src/node/base_node.rs:2857-2859 change collapses a multi-line assert_eq!(dest, s_id, ...) onto one line — exactly the kind of fix this new check now enforces, so it's self-consistent with the PR's purpose.

Observations (all non-blocking)

• Step ordering: Check Format sits between Install Tools and Run Lint. Placing the format check before lint is reasonable (fast, cheap failure). No change needed.
• Pre-existing, out of scope: Makefile:1 and :7 use .PHONEY (typo for .PHONY), so those targets aren't actually declared phony. Harmless here but worth a follow-up cleanup — not something to fix in this PR.
• Pre-existing, out of scope: actions-rs/toolchain@v1 is unmaintained; a future migration to dtolnay/rust-toolchain would be worth considering, but it's unrelated to this change.

No bugs, security, or correctness concerns. LGTM.
• thep2p/ci-fmt-check

[github-actions]

Small, correct, and well-scoped. 'make format' runs 'cargo fmt --all -- --check', which is the right non-mutating choice for CI (fails on unformatted code rather than rewriting). The base_node.rs change is a self-consistent fmt fix. Non-blocking nits: pre-existing .PHONEY typos in the Makefile and the unmaintained actions-rs/toolchain@v1 action, both out of scope here. LGTM.