feat: wire scfit dataloader - #160
Open
selmanozleyen wants to merge 7 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
selmanozleyen
force-pushed
the
feat/scfit-dataloader
branch
from
August 7, 2026 13:28
417ddc0 to
0523caa
Compare
selmanozleyen
force-pushed
the
feat/scfit-dataloader
branch
from
August 7, 2026 14:46
60ba0d6 to
942485c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the data handling utilities in the core methods, improves the interface for slicing and matching batch data, and updates dependencies and API usage for improved compatibility and clarity. The most important changes are summarized below.
Data handling and API refactoring
src/sckitflow/core/_data_utils.py: removes several now-redundant functions (extract_step_data,extract_coupling_data,extract_distribution_data, etc.), and introduces a new, general-purposesubscript_step_datafunction for row-slicing both source and target fields in aStepDatabatch. This centralizes and clarifies batch manipulation logic. [1] [2] [3] [4]subscript_step_data, removing the previous_safe_subscript_objand custom slicing logic fromBaseMethod. This makes the codebase more maintainable and less error-prone. [1] [2] [3]Documentation and interface improvements
StepDatais now fully assembled by the data loaders, not by methods themselves. [1] [2] [3]Dependency and configuration updates
pyproject.toml(anndata>=0.13,scfit>=0.0.7) to support new features and GPU streaming, and adds optional GPU and torch dependencies for improved flexibility. [1] [2]Notebooks and example usage
optim_kwargswithoptim_config, and updates batch size and prediction parameterization for consistency with the refactored interfaces. [1] [2] [3] [4]Method registry and exports
OptimConfigandOptimizationManagerin the core methods module for easier access and consistency with the rest of the API.These changes collectively improve the clarity, maintainability, and extensibility of the codebase, especially around how batches of data are handled and manipulated during training and inference.