Feat/speedup base method - #119
Open
marie-minaeva wants to merge 3 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Pull request overview
This PR optimizes tensor conversion paths in the Torch backend base method and adjusts benchmark/documentation assets (removing a toy notebook and adding a benchmark training config).
Changes:
- Optimized
BatchMixin/StateData→torch.Tensorconversions by combining dtype/device transfers and usingtorch.as_tensor. - Removed
docs/notebooks/try_cfm_toy.ipynb. - Added
benchmark/train_config.yamlfor benchmark runs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/sc_flow/backends/torch/methods/_base.py |
Speeds up numpy→torch conversion by combining .to() calls and using as_tensor. |
docs/notebooks/try_cfm_toy.ipynb |
Removes a toy notebook artifact. |
benchmark/train_config.yaml |
Introduces a benchmark config file (currently mismatched to in-repo API parameter names). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+73
to
+74
| # torch.as_tensor is often safer/faster than from_numpy if | ||
| # the input might already be a tensor |
Comment on lines
+16
to
+19
| # Probability Path Configuration | ||
| # Options: "schrodinger_bridge", "linear_gaussian", "linear_dirac", "variance_preserving_dirac" | ||
| probability_path_id: "linear_dirac" | ||
| probability_path_sigma: 0.1 |
Comment on lines
+32
to
+36
| # Hyperparameters | ||
| training: | ||
| batch_size: 256 | ||
| lr: 0.0001 | ||
| n_train_steps: 1000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.