feat: use shared nginx config from iop-gateway#13
Merged
Conversation
vkrizan
marked this pull request as draft
June 19, 2025 15:37
Contributor
Author
ehelms
reviewed
Jun 19, 2025
Member
|
While I do like shoving as much into the container as possible, see comments like https://github.com/RedHatInsights/iop-gateway/pull/6/files#r2157462116 about how we either need a way to configure some parts at runtime or we need to keep these files here. |
Contributor
Author
|
@ehelms The idea is to have the shared pieces configured using |
vkrizan
force-pushed
the
shared-gateway-config
branch
from
June 23, 2025 08:58
31a34c5 to
9d77ce0
Compare
vkrizan
commented
Jun 23, 2025
vkrizan
force-pushed
the
shared-gateway-config
branch
from
June 23, 2025 14:24
9d77ce0 to
c59504c
Compare
vkrizan
marked this pull request as ready for review
June 23, 2025 14:42
ehelms
reviewed
Jun 24, 2025
| $server_ca_cert_secret_name, | ||
| "${service_name}-common-conf", | ||
| "${service_name}-nginx-conf", | ||
| "${service_name}-variable-overrides-conf", |
Member
There was a problem hiding this comment.
Let's drop this since we have no overrides right now, and then implement it in https://github.com/ehelms/puppet-iop/pull/15 ?
Contributor
Author
There was a problem hiding this comment.
Dropped. #15 becomes obsolete after merging this.
Member
|
This needs a rebase, and see comment. |
vkrizan
force-pushed
the
shared-gateway-config
branch
from
June 24, 2025 12:32
c59504c to
67775c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize common gateway configuration.
Requires: RedHatInsights/iop-gateway#6
RHINENG-18837