Skip to content

Fixes #39510 - Replace enzyme test in SkeletonLoader with RTL#11093

Open
kfamilonidis wants to merge 1 commit into
theforeman:developfrom
kfamilonidis:pf5-skeleton-loader
Open

Fixes #39510 - Replace enzyme test in SkeletonLoader with RTL#11093
kfamilonidis wants to merge 1 commit into
theforeman:developfrom
kfamilonidis:pf5-skeleton-loader

Conversation

@kfamilonidis

Copy link
Copy Markdown
Contributor

Fixes #39510: Replace enzyme test in SkeletonLoader with RTL

@Lukshio

Lukshio commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Clean migration for SkeletonLoader. The four fixture cases become four explicit RTL tests, and coverage actually improves (adds an assertion that the empty state is not shown when children are present).

Critical (must fix before merge)

  • None

Suggestions (should fix)

  • Commit message uses Fixes #39510: ... - Foreman's documented convention (and what's used on develop, e.g. Fixes #38653 - Fix settings show endpoint) is Fixes #XXXXX - description with a hyphen, not a colon. Please reformat.

Nice to have (optional)

  • Counting skeleton placeholders via the .react-loading-skeleton class couples the test to react-loading-skeleton's internal markup. Reasonable given the component has no accessible text while loading, just flagging for awareness if the library ever changes its DOM output.

Checklist gaps

  • PR description doesn't call out the new empty-state-hidden-when-children assertion as an intentional coverage improvement over the old snapshot.

@kfamilonidis
kfamilonidis force-pushed the pf5-skeleton-loader branch from 62dbf09 to 43267f9 Compare July 14, 2026 11:59
@kfamilonidis

Copy link
Copy Markdown
Contributor Author

@Lukshio commit title fixed. Added a NOTE for the class assertion.

@kfamilonidis kfamilonidis changed the title Fixes #39510: Replace enzyme test in SkeletonLoader with RTL Fixes #3951 - Replace enzyme test in SkeletonLoader with RTL Jul 15, 2026
@kfamilonidis kfamilonidis changed the title Fixes #3951 - Replace enzyme test in SkeletonLoader with RTL Fixes #39510 - Replace enzyme test in SkeletonLoader with RTL Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants