Fixes #39477 - Replace enzyme test in ImpersonateIcon with RTL#11062
Open
kfamilonidis wants to merge 1 commit into
Open
Fixes #39477 - Replace enzyme test in ImpersonateIcon with RTL#11062kfamilonidis wants to merge 1 commit into
kfamilonidis wants to merge 1 commit into
Conversation
Contributor
SummaryReal improvement over the old snapshot - now tests actual click interactions (open modal, Confirm calls Critical (must fix before merge)
Suggestions (should fix)
Nice to have (optional)
Checklist gaps
|
kfamilonidis
force-pushed
the
pf5-impersonate-icon
branch
from
July 14, 2026 13:16
0fda920 to
5b6d2a2
Compare
Contributor
Author
|
@Lukshio I switched the Tooltip mock from ({ children }) => children (which discarded content) to the content-preserving SettingCell pattern: it renders content into a data-testid="tooltip-content" with its children |
kfamilonidis
force-pushed
the
pf5-impersonate-icon
branch
from
July 14, 2026 14:03
5b6d2a2 to
c46142f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39477: Replace enzyme test in ImpersonateIcon with RTL