Fixes #39383 - add no-magic-numbers js lint rule#11008
Merged
Merged
Conversation
MariaAga
force-pushed
the
lint-magic-numbers
branch
from
June 1, 2026 09:03
14baf3e to
0239ad7
Compare
MariaAga
marked this pull request as ready for review
June 1, 2026 09:03
Member
Author
|
Thanks, updated to have export const MS_PER_SECOND = 1000;
export const PERCENT_MULTIPLIER = 100;
export const HTTP_STATUS_CODES = { ...Also changed the rule to be an error and not a warning so the git action will fail when magic numbers are used (for easier reviewing experience) |
MariaAga
force-pushed
the
lint-magic-numbers
branch
from
June 1, 2026 09:06
0239ad7 to
ca04d1d
Compare
MariaAga
changed the title
stejskalleos
requested changes
Jun 12, 2026
stejskalleos
left a comment
stejskalleos
left a comment
Contributor
There was a problem hiding this comment.
A few last comments; plus it needs a rebase; otherwise, LGTM.
MariaAga
force-pushed
the
lint-magic-numbers
branch
from
July 8, 2026 12:47
ca04d1d to
40d82f2
Compare
Member
Author
|
Thanks @stejskalleos - resolved the comments, rebased, and updated newly added numbers to use consts |
stejskalleos
approved these changes
Jul 13, 2026
nadjaheitmann
added a commit
to ATIX-AG/foreman_snapshot_management
that referenced
this pull request
Jul 13, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
nadjaheitmann
added a commit
to ATIX-AG/foreman_snapshot_management
that referenced
this pull request
Jul 13, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
Member
|
Looks like this made theforeman/foreman_rh_cloud#1231 fail because rh-cloud tests are not pinned to a particular version of foreman. |
Member
Author
|
@Odilhao I'll get to fixing the plugins, or plugins contributors can fix the errors themselves. There are 2 more PRs that effect plugin lint that are awaiting review/merge |
nadjaheitmann
added a commit
to ATIX-AG/foreman_resource_quota
that referenced
this pull request
Jul 14, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
nadjaheitmann
added a commit
to ATIX-AG/foreman_resource_quota
that referenced
this pull request
Jul 14, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
Contributor
which PRs are those? |
3 tasks
Member
Author
jeremylenz
added a commit
to theforeman/foreman_rh_cloud
that referenced
this pull request
Jul 15, 2026
* Fix no-magic-numbers lint errors Foreman core theforeman/foreman#11008 added the no-magic-numbers ESLint rule to the shared lint config used to lint plugin JS via `npm run lint:plugins`. Extract the affected numeric literals into named constants so foreman_rh_cloud's plugin lint check passes again. * Address review: dedupe SECONDS_PER_MINUTE/PERCENT_COMPLETE, document delays - Extract SECONDS_PER_MINUTE and PERCENT_COMPLETE into a shared TaskConstants module used by both TaskHistory and TaskProgress, instead of duplicating the constants in each file. - Add short comments explaining why the polling interval and form submit delay use their specific values, to make them easier to tune.
nadjaheitmann
added a commit
to theforeman/foreman_puppet
that referenced
this pull request
Jul 17, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
MariaAga
pushed a commit
to theforeman/foreman_puppet
that referenced
this pull request
Jul 17, 2026
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add no-magic-numbers lint rule and fix violations
Adds
no-magic-numbersas awarnrule to ESLint config with common values ignored (0-8, pagination sizes, HTTP status codes, etc.).Extracts magic numbers into named constants across ~20 files (e.g.
MS_PER_SECOND,BYTES_PER_KB,TAB_WEIGHT_*, luminance coefficients).Also adds
unameto spellcheck skipWords.This PR was created with AI assistance.